Add hiddenWhenSkeletonIsActive property

[mohn93]

Summary

Add hiddenWhenSkeletonIsActive property which will hide the view when the skeleton animation starts

Requirements (place an x in each of the [ ])

• [ x ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
• [ x ] I've read and agree to the Code of Conduct.

[Juanpe]

Hi @mohn93, thanks for your first contribution 👍

I would like to discuss about that.

Checking your approach...I think it could be a good solution...But my first approach was to notify when the skeleton will/did appear/disappear. Then the developers can modify the views as they want.

What do you think?

[mohn93]

Hi @Juanpe

How your approach will look like can you show me an example, please?

[Juanpe]

Yep, there are two ways to implement it.

Way 1

// override this method when you need to do something before the skeleton appears
extension UIView {
 @objc func skeletonWillAppear() { }
}

Way 2

protocol SkeletonViewDelegate {
 func skeletonViewWillAppear(_ view: UIView)
}

Do the same for did appear and will/did disappear

[mohn93]

Cool
But you know sometimes I need to hide specific view without any boilerplate, so what if I needed to hide a punch of random views, in some hierarchy, and they are not custom views where it's not cool to add more boilerplate to the code, my approach would be more cleaner.

Since I needed this feature in more than one place, I think it would be good if it's just a simple property or anything near this approach.

And no harm if you kept the other two ways you laid out, the developer might need to do something unfamiliar or worth the boilerplate.

[Juanpe]

mmm...actually, I think you're right, as an open-source project we should provide multiples ways to do something. So yep, we're going to include your approach, although we include later the rest of the approaches.

So, I'm going to review the code, because I have some doubts.

Also, I think we should include this new property in the README file, to be clear that you can hide views when the skeleton is active, ok?

Thanks

[mohn93]

Cool, yeah it needs reviewing, maybe you have some considerations that I didn't take in my implementation, so take your time

[Juanpe]

Hi @mohn93, do you know approx when you can update the doc? Thanks

[mohn93]

Hi @mohn93, do you know approx when you can update the doc? Thanks

@Juanpe Sorry for the delay, I've just updated the documentation

[Juanpe]

Thanks for your first contribution 🎉

[ahmedgomaa27]

@Juanpe can you release a new version for this change ?

[Juanpe]

Hi @ahmedgomaa27, Next version will be released today :)

[Juanpe]

version 1.11.0 was published 👍