Compatibility fix for hybrid views for Polymer 1 and 2 #37
Conversation
…nd"> if it is wrapped in <dom-bind>. This makes it impossible to have hybrid views for Polymer 1 and 2 Solution: apply the mirrored version of the Polymer's own solution for this problem: https://github.com/Polymer/polymer/pull/4537/files
|
|
||
| //mirrored implementation of this fix: https://github.com/Polymer/polymer/pull/4537/files | ||
| const firstElemChild = elem.firstElementChild; | ||
| if (firstElemChild && firstElemChild.getAttribute("is") === elem.localName) { |
There was a problem hiding this comment.
Are we fine to do this for <foo><bar is="foo"> as well? (Polymer implements it in dom-* elements only, so by design they are filtering only those.
There was a problem hiding this comment.
How do you know Polymer implements it in dom-* elements only? Looking here it seems that they do it for any element names.
I think it is fine. If it becomes a problem, we can do a hot fix.
There was a problem hiding this comment.
There was a problem hiding this comment.
This is why it works only for dom-* elements
There was a problem hiding this comment.
Can you paste a link to a line?
There was a problem hiding this comment.
Lets hope <foo><bar is="foo"> will not become a feature by that time.
|
Setting as “Finished” because it is:
|
Problem:
juicy-htmldoes not assign the model to<template is="dom-bind">if it is wrapped in<dom-bind>. This makes it impossible to have hybrid views for Polymer 1 and 2Solution: apply the mirrored version of the Polymer's own solution for this problem: https://github.com/Polymer/polymer/pull/4537/files
This was discussed in https://starcounter.slack.com/archives/C5PEXSXQE/p1513614571000221