Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate text-specific scitype definitions into this package #7

Closed
ablaom opened this issue Oct 6, 2021 · 3 comments
Closed

Migrate text-specific scitype definitions into this package #7

ablaom opened this issue Oct 6, 2021 · 3 comments
Assignees
@ablaom

Comments

@ablaom
Copy link
Member

ablaom commented Oct 6, 2021

Following a discussion at ScienificTypes, let's move the definition of scientific types out of ScientificTypesBase, and move the corresponding implementation of scitype out of ScientificTypes, into MLJText, prior to release. This is to reduce the dependencies of those general-use packages.
@ablaom ablaom self-assigned this Oct 6, 2021
@ablaom ablaom mentioned this issue Oct 6, 2021
Closed
7 tasks
@pazzo83
Copy link
Collaborator

pazzo83 commented Oct 7, 2021

Sounds good - should I include this in my current PR or put it in a new one?

@ablaom
Copy link
Member Author

ablaom commented Oct 7, 2021

No. Let me do it, so as to coordinate the releases. I can merge your PR when you finish @storopoli's readme suggestion.

@pazzo83
Copy link
Collaborator

pazzo83 commented Oct 7, 2021

Perfect!

@ablaom ablaom closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ablaom ablaom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pazzo83 @ablaom