-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist for 0.1 release #5
Comments
Maybe a simple "hello world" example with the documentation? |
Agree on all this - what's the best way to set up coverage? I think I saw some output in the CI where our coverage was above 80%. |
Coverage is setup. The readme icon is not showing the coverage for reasons I do not understand, but if I click on it, it takes you to the detailed analysis (which is > 80%). Maybe if we make a few more PR's it will fix itself. As I say, 80% is okay with me but it might be worth just scanning the analysis to see what is missing.
Yes. Just move your code to src/tfidf_transformer.jl and your tests to test/tifid_transformer.jl and add |
Okay, revisiting coverage, I realised that the new scitype tests are orphaned. 🙄 Working on a fix now. edit Done. |
@pazzo83 You happy for me to release this now? |
Absolutely! Thank you for all of your help with this!! |
No worries. Thanks for your patience. |
Great!!! Happy to help you guys! |
These are my suggestions:
master
branch and merge a "For a 0.1 release" PR dev -> master@pazzo83 @storopoli Feel free to add to this.
The text was updated successfully, but these errors were encountered: