Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to prepare for version 0.1 #6

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

pazzo83
Copy link
Collaborator

@pazzo83 pazzo83 commented Oct 5, 2021

See issue here: #5

Changes involve:

  • separating out transformer code from main module file
  • updating README
  • separating out transformer tests from main test file

@pazzo83 pazzo83 requested review from ablaom and storopoli October 5, 2021 20:46
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #6 (a245758) into dev (1057d6a) will not change coverage.
The diff coverage is 80.24%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev       #6   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files           1        2    +1     
  Lines          82       82           
=======================================
  Hits           66       66           
  Misses         16       16           
Impacted Files Coverage Δ
src/MLJText.jl 100.00% <ø> (+19.51%) ⬆️
src/tfidf_transformer.jl 80.24% <80.24%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1057d6a...a245758. Read the comment docs.

Copy link
Collaborator

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just added a small suggestion in the README

README.md Show resolved Hide resolved
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ablaom ablaom merged commit 32b26d3 into dev Oct 7, 2021
@storopoli storopoli deleted the prep_first_release branch October 7, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants