add BM25 and BagOfWords transformers, update tests, update readme, re… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #12 +/- ##
==========================================
+ Coverage 81.05% 88.33% +7.28%
==========================================
Files 3 7 +4
Lines 95 180 +85
==========================================
+ Hits 77 159 +82
- Misses 18 21 +3
Continue to review full report at Codecov.
|
ablaom
reviewed
Dec 16, 2021
ablaom
reviewed
Dec 16, 2021
ablaom
reviewed
Dec 17, 2021
ablaom
reviewed
Dec 17, 2021
ablaom
reviewed
Dec 17, 2021
ablaom
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Thanks @pazzo83 for this very substantial contribution 🎉 .
I have reviewed the PR with mainly the MLJ model API in mind.
@storopoli Are you able to look over some of the core algorithm implentation details? @pazzo83 Be great if you can flag the names of those core functions.
|
Yes I can, but only beginning next week (Final academic semester week is hell now). |
storopoli
approved these changes
Dec 19, 2021
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Co-authored-by: Jose Storopoli <43353831+storopoli@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two new transformers with updated tests and readme,
Also some refactoring since there is some shared code now.