Add MLJ compliant doc-strings - take II #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #23 +/- ##
==========================================
- Coverage 88.04% 87.76% -0.28%
==========================================
Files 7 8 +1
Lines 184 188 +4
==========================================
+ Hits 162 165 +3
- Misses 22 23 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Yes I will take a look this week! Thanks! |
|
@pazzo83 Do you still have some time to look over this? |
|
I am going to try to look at it this weekend!
…On Thu, Sep 22, 2022 at 12:16 AM Anthony Blaom, PhD < ***@***.***> wrote:
@pazzo83 <https://github.com/pazzo83> Do you still have some time to look
over this?
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACDUZUJYSCFXOHDA6UN36Q3V7PMSVANCNFSM6AAAAAAQETMVAA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Again sorry for the delay here! This looks good! Should I merge? |
pazzo83
approved these changes
Sep 30, 2022
I've kicked CompatHelper out of hibernation and all looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #22
@pazzo83 I have a reviewed the original PR, to ensure compliance with the new MLJ standard, but have also made some changes of my own (which involve some paring down of your original strings). Would you have time in the next few weeks to do a final review?
I suggest one begins by looking over the final docstrings generated by a
julia> ?query, as some of the interpolation magic makes it hard to catch all mistakes by just reading code.cc @josephsdavid