Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reports_feature_importances trait. #23

Merged
merged 2 commits into from
Jul 7, 2022
Merged

add reports_feature_importances trait. #23

merged 2 commits into from
Jul 7, 2022

Conversation

OkonSamuel
Copy link
Member

@OkonSamuel OkonSamuel commented Jun 29, 2022

This PR adds a new trait reports_feature_importances which is overloaded for models reporting intrinsic feature importances e.g RandomForestClassifier.

cc. @ablaom

@ablaom
Copy link
Member

ablaom commented Jul 2, 2022

@OkonSamuel Unless you have a new argument against it, I think we rename instrinsic_importances -> feature_importances.

@OkonSamuel OkonSamuel changed the title add reports_intrinsic_importances trait. add reports_feature_importances trait. Jul 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #23 (b64f800) into dev (b3e4064) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           58        59    +1     
=========================================
+ Hits            58        59    +1     
Impacted Files Coverage Δ
src/StatisticalTraits.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e4064...b64f800. Read the comment docs.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @OkonSamuel

@ablaom ablaom merged commit a2c070b into dev Jul 7, 2022
@ablaom ablaom mentioned this pull request Jul 7, 2022
ablaom added a commit that referenced this pull request Jul 7, 2022
* add `reports_feature_importances` trait. (#23)

* add 
eports_intrinsic_importances trait.

* rename 
eports_intrinsic_importances trait to 
eports_feature_importances.

* bump 3.1.0

Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants