Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero_coeffs for ImplicitBasis #49

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Fix zero_coeffs for ImplicitBasis #49

merged 3 commits into from
Jun 14, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 14, 2024

Detected when working on jump-dev/SumOfSquares.jl#355

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (333eddf) to head (be6c8be).

Files Patch % Lines
src/diracs_augmented.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   94.27%   85.54%   -8.73%     
==========================================
  Files          14       14              
  Lines         681      678       -3     
==========================================
- Hits          642      580      -62     
- Misses         39       98      +59     
Flag Coverage Δ
unittests 85.54% <66.66%> (-8.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat merged commit 7760127 into main Jun 14, 2024
20 of 22 checks passed
@blegat blegat mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant