-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rand() #112
Merged
Merged
Implement rand() #112
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5eb84d6
implemented rand for some sets
zsunberg 883dd3e
implementation of random sampling from balls, but tests do not pass
zsunberg 4b1abca
tests pass (except broken)
zsunberg 6fe318f
added implementation notes
zsunberg cb6094a
remove sphere
zsunberg abc7cf3
fix rand for Ball with radius different than 1
zsunberg 01c8c84
fix #113
zsunberg 482ab5f
fix #114
zsunberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
Random.gentype(::Type{<:Domain{T}}) where T = T | ||
|
||
# Random.gentype(::Type{<:ProductDomain{T}}) where T = T | ||
Base.rand(rng::AbstractRNG, s::Random.SamplerTrivial{<:ProductDomain}) = map(i->(rand(rng, i)), factors(s[])) | ||
|
||
# Random.gentype(::Type{DerivedDomain{T}}) where T = Random.gentype(D) | ||
Base.rand(rng::AbstractRNG, s::Random.SamplerTrivial{<:SimpleLazyDomain}) = rand(rng, superdomain(s[])) | ||
|
||
# Ball | ||
# Mapped | ||
|
||
|
||
# Rectangle | ||
# Wrapped | ||
# Product Domain | ||
|
||
# # Maybe | ||
# Sphere |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
using Test, LinearAlgebra, StaticArrays | ||
using Test, LinearAlgebra, StaticArrays, Random | ||
|
||
using DomainSets | ||
using CompositeTypes.Indexing | ||
|
||
include("test_common.jl") | ||
# include("test_common.jl") | ||
include("test_maps.jl") | ||
include("test_generic_domain.jl") | ||
include("test_specific_domains.jl") | ||
include("test_canonical.jl") | ||
include("test_setoperations.jl") | ||
# include("test_generic_domain.jl") | ||
# include("test_specific_domains.jl") | ||
# include("test_canonical.jl") | ||
# include("test_setoperations.jl") | ||
include("test_applications.jl") | ||
include("test_readme.jl") | ||
# include("test_readme.jl") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here you'd want to put a
toexternalpoint(d, outcome_of_map)
around it, whered
is the product domain