Type stability fix

[chriselrod]

Tests still fail, but at least the inference tests no longer do:

to_indices: Test Failed at /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:48
  Expression: #= /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:48 =# @inferred(ArrayInterface.to_indices(a, inds)) == inds == (ArrayInterface.indices(a),)
   Evaluated: (Base.Slice(1:1:2),) == (Base.Slice(1:1:2),) == (Base.Slice(1:1:4),)
Stacktrace:
 [1] macro expansion
   @ ~/Documents/languages/julia/usr/share/julia/stdlib/v1.8/Test/src/Test.jl:479 [inlined]
 [2] macro expansion
   @ ~/.julia/dev/ArrayInterface/test/indexing.jl:48 [inlined]
 [3] macro expansion
   @ ~/Documents/languages/julia/usr/share/julia/stdlib/v1.8/Test/src/Test.jl:1375 [inlined]
 [4] top-level scope
   @ ~/.julia/dev/ArrayInterface/test/indexing.jl:33
to_indices: Test Failed at /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:55
  Expression: #= /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:55 =# @inferred(ArrayInterface.to_indices(a, (1, :))) == (1, Base.Slice(1:2))
   Evaluated: (1, Base.Slice(1:1:1)) == (1, Base.Slice(1:2))
Stacktrace:
 [1] macro expansion
   @ ~/Documents/languages/julia/usr/share/julia/stdlib/v1.8/Test/src/Test.jl:479 [inlined]
 [2] macro expansion
   @ ~/.julia/dev/ArrayInterface/test/indexing.jl:55 [inlined]
 [3] macro expansion
   @ ~/Documents/languages/julia/usr/share/julia/stdlib/v1.8/Test/src/Test.jl:1375 [inlined]
 [4] top-level scope
   @ ~/.julia/dev/ArrayInterface/test/indexing.jl:33
to_indices: Test Failed at /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:57
  Expression: #= /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:57 =# @inferred(ArrayInterface.to_indices(a, ([true, true], :))) == (Base.LogicalIndex(Bool[1, 1]), Base.Slice(1:2))
   Evaluated: ([1, 2], Base.Slice(1:1:1)) == ([1, 2], Base.Slice(1:2))
Stacktrace:
 [1] macro expansion
   @ ~/Documents/languages/julia/usr/share/julia/stdlib/v1.8/Test/src/Test.jl:479 [inlined]
 [2] macro expansion
   @ ~/.julia/dev/ArrayInterface/test/indexing.jl:57 [inlined]
 [3] macro expansion
   @ ~/Documents/languages/julia/usr/share/julia/stdlib/v1.8/Test/src/Test.jl:1375 [inlined]
 [4] top-level scope
   @ ~/.julia/dev/ArrayInterface/test/indexing.jl:33
Test Summary:     | Pass  Fail  Total  Time
to_indices        |   21     3     24  0.9s
  linear indexing |    4            4  0.0s
ERROR: LoadError: Some tests did not pass: 21 passed, 3 failed, 0 errored, 0 broken.
in expression starting at /Users/chriselrod/.julia/dev/ArrayInterface/test/indexing.jl:32
in expression starting at /Users/chriselrod/.julia/dev/ArrayInterface/test/runtests.jl:831

[ChrisRackauckas]

ouch.

[chriselrod]

Maybe we should file a Julia issue on the branch no longer inferring?

[ChrisRackauckas]

Yeah, this seems like a pretty rough case to not specialize.

[N5N3]

Looks similar to JuliaLang/julia#43368.

[codecov]

Codecov Report

Merging #230 (3c4581a) into master (ec8d2c7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files          11       11           
  Lines        1592     1592           
=======================================
  Hits         1402     1402           
  Misses        190      190           

Impacted Files	Coverage Δ
src/ArrayInterface.jl	85.87% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8d2c7...3c4581a. Read the comment docs.

[Tokazama]

@chriselrod, does this need a review or are we waiting on upstream changes?

[chriselrod]

@chriselrod, does this need a review or are we waiting on upstream changes?

Needs a review. I don't think we should wait for JuliaLang/julia#43368 to get fixed.