Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal interface for index labels #412

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minimal interface for index labels #412

wants to merge 4 commits into from

Conversation

Tokazama
Copy link
Member

This follows up on #328 but drastically reduces complexity. I'd like to punt the more complex stuff (default labels, looking up labels, etc.) to future work so we can actually take advantage of the bike-shedding that's already been done.

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #412 (08f8d01) into master (796eb67) will increase coverage by 0.10%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   76.55%   76.65%   +0.10%     
==========================================
  Files           7        7              
  Lines         563      574      +11     
==========================================
+ Hits          431      440       +9     
- Misses        132      134       +2     
Impacted Files Coverage Δ
src/ArrayInterface.jl 69.27% <90.90%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant