Various fixes to make the package work with v0.5 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # test/subviews.jl
|
Hi @lindahua! Long time no see :) |
|
If there is no objection, I will merge this in one day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to bring this package up to date, and in particular to make it work with v0.5.
To avoid the conflict with
Base.view. This PR deprecatesviewandunsafe_viewin favour of new namesaviewandunsafe_aview.I just run the benchmark again.
Base.viewseems to be as fast asunsafe_aviewfor most cases. To be honest, the mission of this package has completed.