-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations on 0.6 #53
Conversation
FemtoClearner will do even more if we bump the requirement to Julia 0.6. I can see that tests are failing on 0.5 so this might not be valid on 0.5. I think we should just bump the requirements. |
abstract UnsafeArrayView{T,N,M} <: StridedArrayView{T,N,M} | ||
abstract type StridedArrayView{T,N,M} <: DenseArray{T,N} end | ||
abstract type ArrayView{T,N,M} <: StridedArrayView{T,N,M} end | ||
abstract type UnsafeArrayView{T,N,M} <: StridedArrayView{T,N,M} end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These needs @compat
on 0.5
typealias ContiguousMatrix{T} ContiguousArray{T,2} | ||
ContiguousArray{T,N} = Union{Array{T,N}, ContiguousView{T,N}} | ||
ContiguousVector{T} = ContiguousArray{T,1} | ||
ContiguousMatrix{T} = ContiguousArray{T,2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And these.
Should have pinged you. I looked into the ambiguities in #56 |
I just saw. Perfect! I wasn't sure what I was doing anyway ;) Personally I think it's a good idea to drop 0.5.0 and use 0.6.0. Not sure who else is using this package. I'm just trying to get zero-allocation views, which will hopefully be in the next Julia release anyway. |
How can femtobot be triggered to handle the 0.6.0 deprecations? |
I'm not so sure about that. @yuyichao Have you been doing any work on this? |
I guess you need to define "zero-allocation"....
2 can partially replace 1, and 3 will be a strict superset of 1. 1 or 2 should be doable for the next release. 3 and 4 are not necessarily harder given 2 but both of them are fairly big projects. |
Thanks @yuyichao . Could you clarify what "inline" means? Does |
Doesn't matter. You just need all the user to be inlined. |
What do you mean "doesn't matter"? Could you give an example of an inline usage and a not inline usage? |
It means that the code contains no information to determine if the fun that uses the subarray is inlined or not. |
I'm sorry, but I'm not following. I know what |
Inbounds is just the macro, yes. But inlining does not require the macro. As long as the function is inlined it is, well, inlined..... |
#50 didn't catch these