Loop in copyfirstrow!

JuliaArrays · Apr 20, 2024 · 0fe575c · 0fe575c
1 parent e641472
commit 0fe575c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/fillalgebra.jl b/src/fillalgebra.jl
@@ -237,7 +237,12 @@ end
 _firstcol(C::AbstractMatrix) = first(eachcol(C))
 
 function copyfirstrow!(C)
-    C[begin+1:end, :] .= permutedims(_firstrow(C))
+    # C[begin+1:end, ind] .= permutedims(_firstrow(C))
+    # we loop here as the aliasing check isn't smart enough to
+    # detect that the two sides don't alias, and ends up materializing the RHS
+    for (ind, v) in pairs(_firstrow(C))
+        C[begin+1:end, ind] .= Ref(v)
+    end
     return C
 end
 _firstrow(C::AbstractMatrix) = first(eachrow(C))