add unit test and style

JuliaArrays · Aug 15, 2024 · e84270d · e84270d
1 parent 522b0c8
commit e84270d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/oneelement.jl b/src/oneelement.jl
@@ -427,9 +427,9 @@ function Base.reshape(A::OneElement, shape::Tuple{Vararg{Int}})
 end
 
 #permute
-_permute(x::Tuple, p::Tuple) = ntuple(i -> x[p[i]], length(x))
+_permute(x, p) = ntuple(i -> x[p[i]], length(x))
 permutedims(o::OneElementMatrix) = OneElement(o.val, reverse(o.ind), reverse(o.axes))
-permutedims(o::OneElementVector) = OneElement(o.val, (1, o.ind[1]), (1, length(o)))
+permutedims(o::OneElementVector) = reshape(o, (1, length(o)))
 permutedims(o::OneElement, dims) = OneElement(o.val, _permute(o.ind, dims), _permute(o.axes, dims))
 
 # show

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -2668,14 +2668,15 @@ end
     end
 
     @testset "permutedims" begin
-        v = OneElement(1, (2,3), (2,5))
-        @test permutedims(v) === OneElement(1, (3,2), (5,2))
-        w = OneElement(1,3,5)
-        @test permutedims(w) === OneElement(1, (1,3), (1,5))
-        x = OneElement(1, (1,2,3), (4,5,6))
-        @test permutedims(x, (1,2,3)) === x
-        @test permutedims(x, (3,2,1)) === OneElement(1, (3,2,1), (6,5,4))
-        @test_throws BoundsError permutedims(x, (2,1))
+        v = OneElement(1, (2, 3), (2, 5))
+        @test permutedims(v) === OneElement(1, (3, 2), (5, 2))
+        w = OneElement(1, 3, 5)
+        @test permutedims(w) === OneElement(1, (1, 3), (1, 5))
+        x = OneElement(1, (1, 2, 3), (4, 5, 6))
+        @test permutedims(x, (1, 2, 3)) === x
+        @test permutedims(x, (3, 2, 1)) === OneElement(1, (3, 2, 1), (6, 5, 4))
+        @test permutedims(x, [2, 3, 1]) === OneElement(1, (2, 3, 1), (5, 6, 4))
+        @test_throws BoundsError permutedims(x, (2, 1))
     end
     @testset "show" begin
         B = OneElement(2, (1, 2), (3, 4))