Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow structured type argument in diag #277

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 11, 2023

This helps avoid ambiguities downstream

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #277 (36931f1) into master (8d4d190) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           5        5           
  Lines         857      857           
=======================================
  Hits          856      856           
  Misses          1        1           
Impacted Files Coverage Δ
src/FillArrays.jl 99.73% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit dd44608 into JuliaArrays:master Jul 19, 2023
22 checks passed
@jishnub jishnub deleted the diagsignature branch July 19, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants