Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy _throw_dmrs over from Base #294

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 31, 2023

This is an internal method to throw an error, and we may copy over the definition instead of calling the Base function.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #294 (209420e) into master (fef31cd) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           7        7           
  Lines         871      873    +2     
=======================================
+ Hits          870      872    +2     
  Misses          1        1           
Files Changed Coverage Δ
src/FillArrays.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit fa4494c into JuliaArrays:master Sep 4, 2023
24 checks passed
@jishnub jishnub deleted the throwdmrs branch September 4, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants