meta project quality test with Aqua #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a bunch of tests including ambiguity checks
johnnychen94
changed the title
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 86.29% 90.14% +3.84%
==========================================
Files 2 2
Lines 197 213 +16
==========================================
+ Hits 170 192 +22
+ Misses 27 21 -6
Continue to review full report at Codecov.
|
|
I like it! Thanks for introducing me to Aqua. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How ambiguity is computed is changed in JuliaLang/julia#36962
For the purpose of ambiguity check for this package, it would be pretty much sufficient to only check that we don't contribute more ambiguities to Base and Core.
Aqua is used, instead, to free us from manually maintaining these meta project quality tests.