Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support atsign-unsafe indexing with trailing 1s #17

Merged
merged 3 commits into from
Jan 25, 2017
Merged

Support atsign-unsafe indexing with trailing 1s #17

merged 3 commits into from
Jan 25, 2017

Conversation

timholy
Copy link
Member

@timholy timholy commented Jan 22, 2017

Wrapping certain indexing operations in @unsafe led to errors, which this fixes (and tests). It incidentally optimizes linear indexing in conjunction with @unsafe.

@timholy
Copy link
Member Author

timholy commented Jan 22, 2017

Test failure on nightly is JuliaLang/julia#20175

@alsam
Copy link
Member

alsam commented Jan 25, 2017

Hello Tim, thanks for the pull request!

@alsam alsam merged commit 334f5e1 into master Jan 25, 2017
@timholy timholy deleted the teh/trailing1s branch January 26, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timholy @alsam