Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Adapt to a weak dependency #331

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 15, 2023

This doesn't significantly impact load times, but one may avoid installing one extra dependency

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62e0bd8) 98.67% compared to head (de2af9c) 98.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files           5        6    +1     
  Lines         453      453           
=======================================
  Hits          447      447           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented May 17, 2023

Test failure in the invalidation check is due to JuliaLang/Pkg.jl#3327

@jishnub jishnub merged commit 6090bf4 into JuliaArrays:master Dec 20, 2023
20 checks passed
@jishnub jishnub deleted the adaptext branch December 20, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant