Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchsorted overrides, resolves #85 #86

Merged
merged 6 commits into from
Nov 29, 2019

Conversation

dlfivefifty
Copy link
Member

This works around a segfault in Base's searchsorted with offset indices, see #85 and JuliaLang/julia#33977.

This should eventually be back-ported to Base: perhaps with a simple check in Base.searchsorted:

lo < 0 && return _safe_searchsorted(...)

src/OffsetArrays.jl Outdated Show resolved Hide resolved
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs -> spaces

src/OffsetArrays.jl Outdated Show resolved Hide resolved
@dlfivefifty
Copy link
Member Author

The test errors on nightly seem unrelated:

ERROR: Error when installing package CatIndices:
144MethodError: no method matching install_archive(::Array{String,1}, ::Base.SHA1, ::String)
145Closest candidates are:
146  install_archive(!Matched::Array{Pair{String,Bool},1}, ::Base.SHA1, ::String) at /

@fredrikekre
Copy link
Member

JuliaLang/Pkg.jl#1514

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linux nightly seems outdated for some reason.

.travis.yml Show resolved Hide resolved
@fredrikekre
Copy link
Member

If you also bump the patch number we can release directly.

@fredrikekre fredrikekre merged commit d50463f into JuliaArrays:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants