-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
searchsorted overrides, resolves #85 #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs -> spaces
The test errors on nightly seem unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, linux nightly seems outdated for some reason.
If you also bump the patch number we can release directly. |
This works around a segfault in Base's
searchsorted
with offset indices, see #85 and JuliaLang/julia#33977.This should eventually be back-ported to Base: perhaps with a simple check in
Base.searchsorted
: