StaticArraysCore transition #1045
Conversation
|
Will the docstrings for |
|
Good point, they are currently not. I'll try to fix it. |
|
With the last commit the docstrings show for me locally in the documentation. |
| import StaticArraysCore: SizedArray, SizedVector, SizedMatrix | ||
| import StaticArraysCore: check_array_parameters, convert_ntuple | ||
|
|
||
| # end of StaticArraysCore imports |
There was a problem hiding this comment.
Move the (re)-exports below to this block too maybe?
|
Could you add some docs about this? I.e. describe why it is split like this and that if you just want to add dispatch for StaticArrays you can depend only on the core package (I guess this is the main reason for this split?) |
|
Sure, I'll add some docs about this split. The motivation is primarily covered in this comment: #1023 (comment) . |
There was a problem hiding this comment.
This looks good to me.
I remember it being mentioned that StaticArrays.LU and StaticArrays.QR are also being extended by downstream packages; but it would probably be better to just completely drop those rather than to include them in StaticArraysCore.jl at all.
Co-authored-by: Thomas Christensen <tchr@mit.edu>
|
Extending QR and LU from StaticArrays.jl seems like a rare use case so maybe let's leave it in StaticArrays.jl for now. We can always move them to StaticArraysCore.jl later without any breaking changes. |
|
Is this going to be StaticArrays v1.5.0 ? |
|
Yes, I'll tag it in a moment. |
|
Thanks! |
This PR implements transition to StaticArraysCore.jl, an interface package, as discussed here: #1023 .