Mark typeintersect pure for Julia 1.9

[vchuravy]

Fixes the concrete issue in #1155.

Julia 1.9 favors concrete-eval over constant propagation.
Furthermore the effect system was powered up and many @pure annotation were removed.

With --check-bounds=no concrete-eval is disabled
and we rely entirely on const-prop, which seems to struggle whithout the @pure annotation.

@aviatesk would it be feasible to consider the effects for directing const-prop? We have two situations
where the reliance on concrete-eval has shown itself to be problematic. GPU code with custom method-tables,
and --check-bounds=no.

In Julia 1.10 @pure is deprecated and the testcase in #1155
fails again.

[aviatesk]

@aviatesk would it be feasible to consider the effects for directing const-prop?

Yes, we can do something like JuliaLang/julia#46471 (or even set up a separate system to track const-prop' profitability).

Having said that, typeintersect is not inferrable by const-prop', since the main logic is implemented by C.

[vchuravy]

Having said that, typeintersect is not inferrable by const-prop', since the main logic is implemented by C.

Right it used to have an @pure annotation for that reason.

[ranocha]

Thanks a lot for the fix, @vchuravy! Would it make sense to add some tests for this? This would basically need to call Julia again but with the appropriate command line flags since testing uses bounds checking enabled by default.

[ranocha]

@vchuravy I made a PR adding some tests to your branch. Once it is merged, this PR looks good to me. Thanks a lot for investigating this issue and creating a workaround so quickly!

[ranocha]

This looks good to me and is a great fix for some performance problems we encounter with Julia v1.9 as downstream users of StaticArrays.jl.

[mateuszbaran]

LGTM. Could you just add Julia 1.9-dev to CI testing and bump patch version?

[sloede]

Great, thanks a lot to everyone involved for creating a fix so fast. Once a new version of StaticArrays.jl has been released, I will run some performance benchmarks on Julia v1.9 with --check-bounds=no 🐎