Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize zeros/ones/fill for SOneTo #1234

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Specialize zeros/ones/fill for SOneTo #1234

merged 3 commits into from
Jan 29, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 24, 2024

After this,

julia> zeros(SOneTo(4))
4-element SVector{4, Float64} with indices SOneTo(4):
 0.0
 0.0
 0.0
 0.0

and similarly, ones and fill also return SArrays.

@jishnub
Copy link
Member Author

jishnub commented Jan 24, 2024

Test failure on nightly is unrelated

mateuszbaran
mateuszbaran reviewed Jan 24, 2024
View reviewed changes
src/abstractarray.jl Outdated Show resolved Hide resolved
@mateuszbaran mateuszbaran merged commit a8fd370 into JuliaArrays:master Jan 29, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszbaran mateuszbaran mateuszbaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jishnub @mateuszbaran