Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex multiplication with SHermitianCompact #1264

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

lxvm
Copy link
Contributor

@lxvm lxvm commented Jun 24, 2024

This pr adds some methods to dispatch complex scalar multiplication/division with SHermitianCompact to a correct method using SMatrix. Tests are also added. For other details see #1263

Copy link
Collaborator

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you just bump patch version in Project.toml?

@lxvm
Copy link
Contributor Author

lxvm commented Jun 25, 2024

Thank you, I set the version to 1.9.6

@mateuszbaran mateuszbaran merged commit cc1ed9c into JuliaArrays:master Jun 27, 2024
19 of 24 checks passed
@lxvm lxvm deleted the cmul branch July 2, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants