Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short-form macro for SArray construction #349

Closed
wants to merge 1 commit into from

Conversation

cdsousa
Copy link

@cdsousa cdsousa commented Dec 8, 2017

No description provided.

@mschauer
Copy link
Collaborator

mschauer commented Dec 8, 2017

Ref #24

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 93.368% when pulling 976722f on cdsousa:shortmacro into bb51021 on JuliaArrays:master.

@codecov-io
Copy link

Codecov Report

Merging #349 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   93.36%   93.36%   +<.01%     
==========================================
  Files          37       37              
  Lines        2713     2714       +1     
==========================================
+ Hits         2533     2534       +1     
  Misses        180      180
Impacted Files Coverage Δ
src/StaticArrays.jl 100% <ø> (ø) ⬆️
src/SArray.jl 97.26% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb51021...976722f. Read the comment docs.

Copy link
Member

@andyferris andyferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a sort form is a good idea, works well with the spaceless macro format.

My only question is if this is short for the SArray type constructor, should it be @SA or @sa?

@cdsousa
Copy link
Author

cdsousa commented Jan 17, 2018 via email

@c42f
Copy link
Member

c42f commented Aug 1, 2019

Sorry this PR has languished :-(

However, I think we should close it in favor of a larger rethink of the constructor syntax in the StaticArrays-1.0 timeframe cf. #633 / #636 / #97

@c42f c42f closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants