Generalize exception type #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for JuliaLang/julia#41885
c42f
approved these changes
Aug 20, 2021
| @test_throws( | ||
| "reducing over an empty collection is not allowed", | ||
| mapreduce(nothing, nothing, SVector{0,Int}()) | ||
| ) |
There was a problem hiding this comment.
For anyone (like myself) thinking this use of @test_throws looks confusing... see JuliaLang/julia#41888
That's of course fine, but the fact that it returned an ArgumentError was a bit dicey from the start. One can argue that |
|
(clicked the wrong button, sorry) |
c42f
approved these changes
Aug 21, 2021
There was a problem hiding this comment.
Ah yes, technically this only depends on JuliaLang/julia#41888 which has already been merged. So this seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for JuliaLang/julia#41885