refactor finding consistent value #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
reviewed
Oct 15, 2022
| function findconsistentvalue(f::F, (col, cols...)::Tup) where F | ||
| val = f(col) | ||
| isconsistent = mapfoldl(isequal(val)∘f, &, cols; init=true) | ||
| return ifelse(isconsistent, val, nothing) |
There was a problem hiding this comment.
val might be nothing? I think we can follow Base._all_match_first style here.
There was a problem hiding this comment.
valmight benothing?
Not really, we only use this to compute ranges of indices. If we happen to need that use case, we can always return Some(val), but I'd rather avoid the extra wrapping / unwrapping unless it's needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.