fix breaking bug caused by changes in CSV column format #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look inoffensive to me, but to be honest I don't know anything about this package, so I don't think my review carries much value, but at least tests are passing. @helgee it'd be very helpful if you had a chance to quickly review this, it should be quick. |
|
Sorry, folks. I have zero capacity for maintaining my Julia libraries at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #19 and JuliaAstro/AstroTime.jl#70 which were caused by four additional columns being added to the CSV data format from IERS.
This is a breaking bug, as the new CSV files cannot be read without this modification.
@helgee I'd like a review, as I'm not very familiar with these astrometric variables. The changes are small, and I made them by visually inspecting the new CSV file headers.