This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Fix spurious warnings when file watching on OS X #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call, in the context of file watching, appears to trigger assertion warnings on some macOS configurations. Refs: nodejs/node#854 Fixes: libuv/libuv#1334 PR-URL: libuv/libuv#1349 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
|
Given JuliaLang/julia#25062 recently merged, I think this is only relevant to julia 0.6 now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Revise.jl on my MacBook Pro, my REPL becomes polluted with warnings like the following. It happens every time I save a watched file, but only after something in the file has been called once in julia:
These statements seem to be harmless but they are distracting. I looked around and apparently this issue has been seen elsewhere, is due to libuv, and is now patched upstream. See libuv/libuv#1349 and links therein, especially this one. I cherry-picked that commit and made this PR after having confirmed that I no longer experience problems when I build the latest julia nightly using this branch of libuv.