Add benchmarks for sparse unary minus #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrevels
requested changes
Dec 13, 2016
| # unary operations # | ||
| #################### | ||
|
|
||
| g = addgroup!(SUITE, "unary ops") |
There was a problem hiding this comment.
Hmm, the linear algebra benchmarks have an "arithmetic" group, can we replace "unary ops" with "arithmetic" to make things consistent?
There was a problem hiding this comment.
arithmetic is much better. Thanks!
|
|
||
| # unary minus, julialang repo issue #19503 / fix #19530 | ||
| g["unary ops", "unary minus", size(small_sqr)] = @benchmarkable -$small_sqr | ||
| g["unary ops", "unary minus", size(large_sqr)] = @benchmarkable -$large_sqr |
There was a problem hiding this comment.
The extra group key here isn't necessary, e.g. g["unary ops", "unary minus", size(small_sqr)] can be changed to g["unary minus", size(small_sqr)]
There was a problem hiding this comment.
Fixed on push. Thanks!
|
Awesome, thanks again! I'll let you know once these benchmarks are available on Nanosoldier (they still need to undergo a |
|
Cheers, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds benchmarks for sparse unary minus as discussed in JuliaLang/julia#19530. Apologies in advance for inevitable BaseBenchmarks.jl-newbie errors. Thanks and best!