-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak POST to use pure POST api #1
Conversation
Instead of multipart nonsense, use the undocumented form-data POST API
We can see what the Travis output says, and hope for the best! |
|
https://coveralls.io/r/IainNZ/Coverage.jl |
💯 very grateful! |
Ah, didn't realize you'd already set it up to run alongside travis. Very neat! |
I'm gonna polish it on https://github.com/IainNZ/RationalSimplex.jl (as a test case) then I'm hoping its something people will be able to drop as an extra line in their travis, e.g.
|
Sounds good to me! Neat tools like this make me happy. :) |
I tried this out: https://coveralls.io/r/loladiro/SIUnits.jl. So how does it work? Does it only consider functions that are actually called? |
Yeah if you look at the .cov files, for each line they either have a So it looks like you are missing 3 lines: When I ran this on JuMP.jl almost all the lines not called where error lines/early breakouts that weren't tested. |
But there is also big functions like https://coveralls.io/files/193437379#L377, which don't show up as not covered. |
Also reported here: JuliaLang/julia#5423 seems to be an issue with the tool |
Instead of multipart nonsense, use the undocumented form-data POST API (I got the idea from this guy)
Note that I haven't tested this, since I'm not sure how to run this Coverage.jl thing, but in a REPL session, the following returned me something: