Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support COVERALLS_PARALLEL environment variable #250

Merged
merged 7 commits into from
Nov 25, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 21, 2019

No description provided.

@JuliaCI JuliaCI deleted a comment from codecov-io Nov 21, 2019
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me so far. I assume this will be squashed once completed? It seems there are still some issues to be ironed out, based on the updates this PR already received ... :-). I'll be happy to review this again once it has stabilized.


script:
- julia --check-bounds=yes etc/travis-test.jl
- export COVERALLS_PARALLEL=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a reason to hold up this PR, just wondering, but: is there any reason to do it like this, and now how the README suggests to do i? I.e.,

env:
  global:
    - COVERALLS_PARALLEL=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that it confuses testing to set it globally. We similarly don't use the suggested script either.

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #250 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   90.22%   90.31%   +0.08%     
==========================================
  Files           6        6              
  Lines         348      351       +3     
==========================================
+ Hits          314      317       +3     
  Misses         34       34
Impacted Files Coverage Δ
src/coveralls.jl 81.08% <100%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3c9e2...15bc126. Read the comment docs.

@vtjnash
Copy link
Member Author

vtjnash commented Nov 25, 2019

I'll be happy to review this again once it has stabilized.

Yeah, was just making all of the edits in the GitHub editor, so I could only do one file at a time. If it wasn't clear, it should be done now. I planned to squash-and-merge.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good (assuming it'll be squashed, as you said)

README.md Outdated Show resolved Hide resolved
@vtjnash vtjnash merged commit bd7fe77 into master Nov 25, 2019
@vtjnash vtjnash deleted the jn/COVERALLS_PARALLEL branch November 25, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants