-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support COVERALLS_PARALLEL environment variable #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me so far. I assume this will be squashed once completed? It seems there are still some issues to be ironed out, based on the updates this PR already received ... :-). I'll be happy to review this again once it has stabilized.
|
||
script: | ||
- julia --check-bounds=yes etc/travis-test.jl | ||
- export COVERALLS_PARALLEL=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a reason to hold up this PR, just wondering, but: is there any reason to do it like this, and now how the README suggests to do i? I.e.,
env:
global:
- COVERALLS_PARALLEL=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that it confuses testing to set it globally. We similarly don't use the suggested script either.
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 90.22% 90.31% +0.08%
==========================================
Files 6 6
Lines 348 351 +3
==========================================
+ Hits 314 317 +3
Misses 34 34
Continue to review full report at Codecov.
|
Yeah, was just making all of the edits in the GitHub editor, so I could only do one file at a time. If it wasn't clear, it should be done now. I planned to squash-and-merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good (assuming it'll be squashed, as you said)
Co-Authored-By: Max Horn <max@quendi.de>
No description provided.