Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memalloc: remove dead code #294

Merged
merged 1 commit into from
Nov 17, 2020
Merged

memalloc: remove dead code #294

merged 1 commit into from
Nov 17, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 17, 2020

This is not how packages in Julia are used, especially since precompile. If we wanted something like this back, it would be more logical to have a simple script bin/memalloc to drive this functionality.

Closes #98

@vtjnash
memalloc: remove dead code
2091fa8 
This is not how packages in Julia are used, especially since precompile. If we wanted something like this back, it would be more logical to have a simple script `bin/memalloc` to drive this functionality.

Closes #98
@coveralls
Copy link

coveralls commented Nov 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%
Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157
💛 - Coveralls

4 similar comments
@coveralls
Copy link

coveralls commented Nov 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%
Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%
Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%
Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%
Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157
💛 - Coveralls

@fingolfin fingolfin merged commit 1d79890 into master Nov 17, 2020
@fingolfin fingolfin deleted the jn/98 branch November 17, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document calling from command line
3 participants
@vtjnash @coveralls @fingolfin