Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase instructions for local usage #327

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Rephrase instructions for local usage #327

merged 1 commit into from
Oct 20, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Oct 15, 2021

The rewords some of the instructions in the README for local coverage measurement. The major changes & their motivations are:

  • indicate the purpose of each step before describing the mechanics of the step. This also makes it easier to indicate that one does not necessarily need to measure summary statistics if one's only goal is to find lines lacking coverage.
  • prioritize Pkg.test(; coverage=true) above manual measurement. Most users will want the simpler option.
  • clarify the role of the .info tracefile. This allows users to determine when they need to supply the more complex set of options. By presenting it as a choice it also makes it clearer that you don't need to execute both lines.
  • acknowledge limitations in the accuracy of Julia's coverage analysis

The rewords some of the instructions in the README for local coverage measurement. The major changes & their motivations are:

- indicate the purpose of each step before describing the mechanics of the step. This also makes it easier to indicate that one does not necessarily need to measure summary statistics if one's only goal is to find lines lacking coverage.
- prioritize `Pkg.test(; coverage=true)` above manual measurement. Most users will want the simpler option.
- clarify the role of the `.info` tracefile. This allows users to determine when they need to supply the more complex set of options. By presenting it as a choice it also makes it clearer that you don't need to execute both lines.
- acknowledge limitations in the accuracy of Julia's coverage analysis
@coveralls
Copy link

coveralls commented Oct 15, 2021

Pull Request Test Coverage Report for Build 1345843085

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 90.865%

Files with Coverage Reduction New Missed Lines %
src/codecovio.jl 2 87.38%
src/coveralls.jl 2 94.29%
Totals Coverage Status
Change from base Build 1308404670: 0.5%
Covered Lines: 189
Relevant Lines: 208

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #327 (a7a3088) into master (c3fe9bc) will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   90.09%   90.56%   +0.47%     
==========================================
  Files           2        2              
  Lines         212      212              
==========================================
+ Hits          191      192       +1     
+ Misses         21       20       -1     
Impacted Files Coverage Δ
src/coveralls.jl 94.28% <0.00%> (-1.91%) ⬇️
src/codecovio.jl 86.91% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3fe9bc...a7a3088. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Oct 20, 2021

This is for a class I'm teaching, and the homework gets assigned today, so I'll merge.

@timholy timholy merged commit e22e4fe into master Oct 20, 2021
@timholy timholy deleted the teh/reword_README branch October 20, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants