Skip to content

Commit

Permalink
replace jrevels with that sleek new maintainer ararslan (#35)
Browse files Browse the repository at this point in the history
  • Loading branch information
jrevels authored Jul 11, 2017
1 parent 4c8fb3d commit 2748fc8
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,14 @@ branch.
I want to run all benchmarks on the current commit. I want to compare the results
against a commit on my fork.
@nanosoldier `runbenchmarks(ALL, vs = "jrevels/julia@c70ab26bb677c92f0d8e0ae41c3035217a4b111f")`
@nanosoldier `runbenchmarks(ALL, vs = "ararslan/julia@c70ab26bb677c92f0d8e0ae41c3035217a4b111f")`
```

```
I want to run all benchmarks on the current commit. I want to compare the results
against the head commit of my fork's branch.
@nanosoldier `runbenchmarks(ALL, vs = "jrevels/julia:mybranch")`
@nanosoldier `runbenchmarks(ALL, vs = "ararslan/julia:mybranch")`
```

## Acknowledgements
Expand Down
4 changes: 2 additions & 2 deletions bin/setup_test_ci.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ secret = ENV["GITHUB_SECRET"]

config = Nanosoldier.Config(ENV["USER"], nodes, cpus, auth, secret;
workdir = joinpath(homedir(), "test_workdir"),
trackrepo = "jrevels/julia",
reportrepo = "jrevels/BaseBenchmarkReports",
trackrepo = "ararslan/julia",
reportrepo = "ararslan/BaseBenchmarkReports",
testmode = true)

server = Nanosoldier.Server(config)
8 changes: 4 additions & 4 deletions src/jobs/BenchmarkJob.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ end
function BenchmarkJob(submission::JobSubmission)
if haskey(submission.kwargs, :vs)
againststr = parse(submission.kwargs[:vs])
if in(SHA_SEPARATOR, againststr) # e.g. againststr == jrevels/julia@e83b7559df94b3050603847dbd6f3674058027e6
if in(SHA_SEPARATOR, againststr) # e.g. againststr == ararslan/julia@e83b7559df94b3050603847dbd6f3674058027e6
reporef, againstsha = split(againststr, SHA_SEPARATOR)
againstrepo = isempty(reporef) ? submission.config.trackrepo : reporef
againstbuild = BuildRef(againstrepo, againstsha)
Expand Down Expand Up @@ -393,7 +393,7 @@ function report(job::BenchmarkJob, results)
cfg = submission(job).config
if haskey(results, "primary") && isempty(results["primary"])
reply_status(job, "error", "no benchmarks were executed")
reply_comment(job, "[Your benchmark job]($(submission(job).url)) has completed, but no benchmarks were actually executed. Perhaps your tag predicate contains misspelled tags? cc @jrevels")
reply_comment(job, "[Your benchmark job]($(submission(job).url)) has completed, but no benchmarks were actually executed. Perhaps your tag predicate contains misspelled tags? cc @ararslan")
else
# prepare report + data and push it to report repo
target_url = ""
Expand Down Expand Up @@ -433,9 +433,9 @@ function report(job::BenchmarkJob, results)
# reply with the job's final status
reply_status(job, state, status, target_url)
if isempty(target_url)
comment = "[Your benchmark job]($(submission(job).url)) has completed, but something went wrong when trying to upload the result data. cc @jrevels"
comment = "[Your benchmark job]($(submission(job).url)) has completed, but something went wrong when trying to upload the result data. cc @ararslan"
else
comment = "[Your benchmark job]($(submission(job).url)) has completed - $(status). A full report can be found [here]($(target_url)). cc @jrevels"
comment = "[Your benchmark job]($(submission(job).url)) has completed - $(status). A full report can be found [here]($(target_url)). cc @ararslan"
end
reply_comment(job, comment)
end
Expand Down
2 changes: 1 addition & 1 deletion src/server.jl
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function delegate_job(server::Server, job::AbstractJob, node)
message *= "Logs and partial data can be found [here]($(err.url))\n"
end
end
message *= "cc @jrevels"
message *= "cc @ararslan"
nodelog(server.config, node, err_str)
reply_status(job, "error", err_str)
reply_comment(job, message)
Expand Down
2 changes: 1 addition & 1 deletion test/report.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Job Properties

*Commit(s):* [jrevels/julia@25c3659d6cec2ebf6e6c7d16b03adac76a47b42a](https://github.com/jrevels/julia/commit/25c3659d6cec2ebf6e6c7d16b03adac76a47b42a) vs [JuliaLang/julia@bb73f3489d837e3339fce2c1aab283d3b2e97a4c](https://github.com/JuliaLang/julia/commit/bb73f3489d837e3339fce2c1aab283d3b2e97a4c)
*Commit(s):* [ararslan/julia@25c3659d6cec2ebf6e6c7d16b03adac76a47b42a](https://github.com/ararslan/julia/commit/25c3659d6cec2ebf6e6c7d16b03adac76a47b42a) vs [JuliaLang/julia@bb73f3489d837e3339fce2c1aab283d3b2e97a4c](https://github.com/JuliaLang/julia/commit/bb73f3489d837e3339fce2c1aab283d3b2e97a4c)

*Triggered By:* [link](https://www.test.com)

Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz:
LLVM: libLLVM-3.3
"""

primary = BuildRef("jrevels/julia", "25c3659d6cec2ebf6e6c7d16b03adac76a47b42a", vinfo)
primary = BuildRef("ararslan/julia", "25c3659d6cec2ebf6e6c7d16b03adac76a47b42a", vinfo)
against = Nullable(BuildRef("JuliaLang/julia", "bb73f3489d837e3339fce2c1aab283d3b2e97a4c", vinfo*"_against"))
config = Config("user", [1], [1], GitHub.AnonymousAuth(), "test");
tagpred = "ALL && !(\"tag1\" || \"tag2\")"
Expand Down

0 comments on commit 2748fc8

Please sign in to comment.