Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use BenchmarkTools v0.0.7 #28

Merged
merged 2 commits into from
Feb 7, 2017
Merged

update to use BenchmarkTools v0.0.7 #28

merged 2 commits into from
Feb 7, 2017

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Feb 4, 2017

This will require JuliaCI/BenchmarkTools.jl#43 and a subsequent v0.0.7 tag for BenchmarkTools.

I'll probably have to do some manual test runs once this PR is ready.

jrevels referenced this pull request in JuliaLang/julia Feb 7, 2017
…0461)

make fftshift and ifftshift take iterables as dimension arguments
@jrevels
Copy link
Member Author

jrevels commented Feb 7, 2017

This requires JuliaLang/METADATA.jl#7863 in order for Travis to pass on v0.6

@jrevels jrevels merged commit 82b8523 into master Feb 7, 2017
@jrevels jrevels deleted the jr/toolsupgrade branch February 7, 2017 19:46
@jrevels
Copy link
Member Author

jrevels commented Feb 7, 2017

I'll comment here once this has been deployed to Nanosoldier (I'm doing some cleanup work to update packages right now before running some tests, so it won't be for at least another few hours).

julia:
- release
- nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the nightly cron job will cover this? Or does the Nanosoldier.jl code only run on the coordinator node with a fixed release Julia?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does the Nanosoldier.jl code only run on the coordinator node with a fixed release Julia?

This. I'm never going to be running the server on a non-release version of Julia (right now it's the latest v0.5 release).

@jrevels
Copy link
Member Author

jrevels commented Feb 8, 2017

Alright, the new-and-improved Nanosoldier is up and running.

Nanosoldier passed a normal PR vs. master benchmark job, but I don't have time to test daily=true before the next daily job is triggered (45 minutes from now), so I'm just gonna let Nanosoldier undergo trial by fire since there's no downside to doing so compared to the current state of affairs. Fingers crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants