-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to evaluate package loadability. #272
base: master
Are you sure you want to change the base?
Conversation
Example report: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/e0656ac/report.html This will need some additional fixes across the PkgEval stack to ensure @KristofferC Thoughts on this change? It was motivated by having additional coverage on loadability of packages when they're blacklisted because of test failures, but we'll need to be careful that it's clearly shown as such. |
6e8893c
to
beda9ea
Compare
This regressed PkgEval times from 10h to 18h, so I'll likely revert this. Example run: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/3124e4e_vs_309021d/report.html |
8f14577
to
be75e2c
Compare
Use that as the fallback for blacklisted packages.
be75e2c
to
732231e
Compare
Switching to not using TestEnv, but only compiling the actual package, results in much better timings: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/3236e12_vs_17857ca/report.html I wonder if somethings up here, or if it's really test dependencies accounting for so much of the total PkgEval time... EDIT: Oh, looks like GitHub had an outage and many packages weren't tested... |
Use that as the fallback for blacklisted packages.
Fixes #271
Will only deploy next week.