Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the package_linux images to work even with make USE_BINARYBUILDER=0 #124

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Fix the package_linux images to work even with make USE_BINARYBUILDER=0 #124

merged 4 commits into from
Oct 12, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Oct 11, 2021 •
edited
Loading

No description provided.

@DilumAluthge DilumAluthge marked this pull request as draft October 11, 2021 05:23
@DilumAluthge DilumAluthge force-pushed the dpa/package-linux-use-bb-0 branch from 71e14b0 to 3e536b6 Compare October 11, 2021 05:31
@DilumAluthge
Copy link
Member Author

@staticfloat I need to actually check that this is sufficient 😂.

@DilumAluthge
Copy link
Member Author

Okay, when testing locally, these additions seem sufficient for building a non-BinaryBuilder build.

@DilumAluthge
Copy link
Member Author

ccache isn't actually necessary for a non-BinaryBuilder build. But it will speed up LLVM builds in the future, as long as we persist the ccache directory between runs.

@DilumAluthge DilumAluthge marked this pull request as ready for review October 12, 2021 03:20
@staticfloat staticfloat merged commit 68055a7 into main Oct 12, 2021
@staticfloat staticfloat deleted the dpa/package-linux-use-bb-0 branch October 12, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @staticfloat