WIP: Get things working on v0.5 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.05% (diff: 100%)@@ master #212 diff @@
==========================================
Files 27 27
Lines 2288 2291 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2057 2109 +52
+ Misses 231 182 -49
Partials 0 0
|
| @@ -2,6 +2,7 @@ using Base.Test | |||
| using DataStructures | |||
| const IntSet = DataStructures.IntSet | |||
| import Compat: String | |||
| using Primes | |||
There was a problem hiding this comment.
Where does this get used?
There was a problem hiding this comment.
The Primes package provides the primes function, which is deprecated in Base right?
|
LGTM. |
|
@Keno @StefanKarpinski @tkelman can one of you guys tag a new release please? |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
complementandcomplement!. Fixing tests now. Comments and suggestions welcome as I go along.Fixes #209
cc: @kmsquire @phaverty @tkelman