Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.6 depwarns #268

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix 0.6 depwarns #268

merged 1 commit into from
Feb 10, 2017

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Feb 9, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #268 into master will not change coverage.

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          30       30           
  Lines        2223     2223           
=======================================
  Hits         2131     2131           
  Misses         92       92
Impacted Files Coverage Δ
src/trie.jl 93.22% <100%> (ø)
src/disjoint_set.jl 97.87% <100%> (ø)
src/heaps/binary_heap.jl 100% <100%> (ø)
src/circular_buffer.jl 100% <100%> (ø)
src/balanced_tree.jl 100% <100%> (ø)
src/deque.jl 100% <100%> (ø)
src/ordered_set.jl 98.14% <100%> (ø)
src/sorted_multi_dict.jl 92.45% <100%> (ø)
src/heaps/mutable_binary_heap.jl 92.66% <100%> (ø)
src/sorted_set.jl 94.15% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76106b5...e4dabef. Read the comment docs.

@kmsquire
Copy link
Member

kmsquire commented Feb 9, 2017

Hi @yuyichao, I can probably find it, but could you point to the change in Base that requires this? I think it significantly detracts from readability, and want to discuss that more in the original issue. (Will look for it later if you don't respond.)

@yuyichao
Copy link
Contributor Author

yuyichao commented Feb 9, 2017

The corresponding PR is JuliaLang/julia#20308, which does not require this syntax but this is the simplest way I can find to make it work on old versions.

@yuyichao
Copy link
Contributor Author

Note that it is possible to get some form of the new syntax to work on old versions but it'll either require duplicating the code or quite involved hack in @compat. Given that the ::Type{...} trick works and seems to be accepted by people so far, I'm not too excited about implementing anything fancy in @compat now.....

@yuyichao yuyichao merged commit 79a03f1 into JuliaCollections:master Feb 10, 2017
@yuyichao yuyichao deleted the yyc/0.6 branch February 10, 2017 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants