Implement LittleSet (follow-up on #95)
#107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overcomes the issue with Julia v1.6 not supporting replace for tuples and does a better job working around the opaque tuple variant
fingolfin
reviewed
Nov 24, 2024
Comment on lines
+61
to
+63
| # `data` should not be directly accessed | ||
| Base.propertynames(@nospecialize(x::LittleSet)) = () | ||
| function Base.propertynames(@nospecialize(x::LittleSet), ::Symbol) |
There was a problem hiding this comment.
This is highly unusual and no other type in this package does this.
fingolfin
reviewed
Nov 24, 2024
| # `data` should not be directly accessed | ||
| Base.propertynames(@nospecialize(x::LittleSet)) = () | ||
| function Base.propertynames(@nospecialize(x::LittleSet), ::Symbol) | ||
| throw(ArgumentError("LittleSet does not support public access to it's fields.")) |
There was a problem hiding this comment.
Suggested change
| throw(ArgumentError("LittleSet does not support public access to it's fields.")) | |
| throw(ArgumentError("LittleSet does not support public access to its fields.")) |
fingolfin
reviewed
Nov 24, 2024
| # `FrozenLittleSet{T, Tuple{Vararg{T}}}`), these methods allow accessing data without exposing the | ||
| # underlying `data` field and unintentionally specializing downstream code on the exact type | ||
| # representation of a tuple. | ||
| if isdefined(Base, Symbol("@assume_effects")) |
There was a problem hiding this comment.
This doesn't work in Julia 1.6 (see CI failure). Perhaps this will?
Suggested change
| if isdefined(Base, Symbol("@assume_effects")) | |
| @static if isdefined(Base, Symbol("@assume_effects")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated go at #95 thats more feature complete and tests