Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(live): allow multiple default images for a product #43

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Nov 20, 2023

This should resolve the live test failures, and future-proof the tests against any future configuration problems.

@mortenpi mortenpi changed the title test: allow multiple default images for a product test(live): allow multiple default images for a product Nov 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27e5c72) 76.98% compared to head (1393d7b) 77.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   76.98%   77.96%   +0.98%     
==========================================
  Files          16       16              
  Lines        2233     2233              
==========================================
+ Hits         1719     1741      +22     
+ Misses        514      492      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mortenpi mortenpi marked this pull request as ready for review November 20, 2023 08:16
@mortenpi mortenpi enabled auto-merge (squash) November 20, 2023 08:17
@mortenpi mortenpi merged commit 4f0c73a into main Nov 20, 2023
11 checks passed
@mortenpi mortenpi deleted the mp/multiple-default-images branch November 20, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants