-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle backend responses more gracefully in datasets requests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 78.37% 78.49% +0.11%
==========================================
Files 16 16
Lines 2234 2241 +7
==========================================
+ Hits 1751 1759 +8
+ Misses 483 482 -1 ☔ View full report in Codecov by Sentry. |
pfitzseb
reviewed
Jan 17, 2024
mortenpi
commented
Jan 18, 2024
mortenpi
commented
Jan 18, 2024
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
mortenpi
commented
Jan 18, 2024
pfitzseb
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles problematic dataset list backend responses more gracefully, by printing one warning per call, rather than throwing an error.
Also, unrelated to the main change, but makes the
auth
argument of the internal_get_datasets
function positional, for consistency.