Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle backend responses more gracefully in datasets requests #46

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

mortenpi
Copy link
Member

Handles problematic dataset list backend responses more gracefully, by printing one warning per call, rather than throwing an error.

Also, unrelated to the main change, but makes the auth argument of the internal _get_datasets function positional, for consistency.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7394f23) 78.37% compared to head (7f4762e) 78.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   78.37%   78.49%   +0.11%     
==========================================
  Files          16       16              
  Lines        2234     2241       +7     
==========================================
+ Hits         1751     1759       +8     
+ Misses        483      482       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/datasets.jl Outdated Show resolved Hide resolved
test/datasets.jl Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
src/datasets.jl Outdated Show resolved Hide resolved
@mortenpi mortenpi enabled auto-merge (squash) January 18, 2024 08:23
@mortenpi mortenpi merged commit af5fed3 into main Jan 18, 2024
11 checks passed
@mortenpi mortenpi deleted the mp/graceful-get-datasets branch January 18, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants