-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ensure consistent Julia environments in live job tests #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
===========================================
- Coverage 78.49% 40.74% -37.75%
===========================================
Files 16 16
Lines 2241 2216 -25
===========================================
- Hits 1759 903 -856
- Misses 482 1313 +831 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also attach only Project.toml for testing as the job code will resolve the Project.toml into a valid Manifest.toml
This should cover most cases (I think only these stdlib changes could affect it somehow)
This works too, so feel free to use the above if you think it could help
One of the tests specifically submits the same job twice, once with a Manifest and then without, and detects the environment difference. |
JuliaHub jobs have a fixed Julia version (1.9 presently), so you need to make sure you submit a
Manifest.toml
that is compatible with it. However, the current live tests sometimes resolve things with the running Julia version, and we run the tests with a whole range of Julia versions. With nightly Julia builds, this now causes issues (specifically, theStyledStrings
standard library is not available on older Julia versions).script""noenv
for all the tests that submit simple scripts. Standardscript""
attaches the currently running environment, which may declare dependencies that are not valid when running with a different Julia version. Those tests don't require any packages.job1
manifest to 1.9.