feat: add progress kwarg for upload_dataset #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 78.49% 78.52% +0.02%
==========================================
Files 16 16
Lines 2241 2244 +3
==========================================
+ Hits 1759 1762 +3
Misses 482 482 ☔ View full report in Codecov by Sentry. |
progress=false disables rclone's progress printing
pfitzseb
force-pushed
the
sp/progress-option
branch
from
a25cdd0
to
8357732
Compare
mortenpi
reviewed
Feb 20, 2024
|
We should also mention this in the docstring I presume, unless you intended this as an unofficial feature? |
Co-authored-by: Morten Piibeleht <morten.piibeleht@juliahub.com>
mortenpi
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I think the nightly failures are unrelated, but will double check.
Edit: Yep, we're getting the RequestError also on main: https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/7785543661/job/21792097289#step:7:112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress=false disables rclone's progress printing