Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix Aqua workflow #59

Merged
merged 6 commits into from
Jun 18, 2024
Merged

test: fix Aqua workflow #59

merged 6 commits into from
Jun 18, 2024

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jun 17, 2024 •
edited
Loading

  • continue-on-error: true means that the Aqua job was failing, but it didn't show up on CI (e.g. here).
  • However, the errors are non-actionable, so I'm configuring Aqua to ignore these for now.

Hopefully we'll catch any future errors though.

@mortenpi mortenpi requested a review from a team June 17, 2024 22:53
@mortenpi mortenpi changed the title ci: fix Aqua workflow test: fix Aqua workflow Jun 17, 2024
@mortenpi mortenpi enabled auto-merge (squash) June 17, 2024 23:23
@mortenpi mortenpi disabled auto-merge June 17, 2024 23:23
@mortenpi mortenpi enabled auto-merge (squash) June 17, 2024 23:23
@mortenpi mortenpi disabled auto-merge June 17, 2024 23:24
@mortenpi mortenpi merged commit 5551e30 into main Jun 18, 2024
12 checks passed
@mortenpi mortenpi deleted the mp/aqua branch June 18, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfitzseb pfitzseb pfitzseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortenpi @pfitzseb