Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#64 fix display precision of big numbers #65

Merged
merged 9 commits into from
Mar 16, 2021

Conversation

baumgold
Copy link
Contributor

@baumgold baumgold commented Jan 20, 2021

Rafactor and simplify the table2json method as follows:

  • Finite numbers larger than 2^53-1 or smaller than -2^53-1 will be treated as a string and enclosed in double-quotes
  • Nothing and Missing will use the repr function to convert to string
  • Everything else will use the print function to convert to string
  • Use JSON helper methods to generate the JSON string
  • Reduce indentation for improved readability

Closes #64

@pfitzseb pfitzseb self-requested a review January 29, 2021 17:00
@baumgold
Copy link
Contributor Author

@pfitzseb - Any comments here? Thanks!

@pfitzseb pfitzseb merged commit 006c4e3 into JuliaComputing:master Mar 16, 2021
@baumgold baumgold deleted the imprecise_big_numbers branch March 16, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imprecise big number display
2 participants