Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of precompilation statements #108

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

giordano
Copy link
Member

main (da1ccc1):

% julia +1.7 --startup-file=no --project=/tmp -q
julia> using Sandbox; @time @eval Sandbox.select_executor(false);
  2.771236 seconds (10.20 M allocations: 540.632 MiB, 7.27% gc time, 100.00% compilation time)

% julia +1.8 --startup-file=no --project=/tmp -q
julia> using Sandbox; @time @eval Sandbox.select_executor(false);
  2.598736 seconds (8.77 M allocations: 448.371 MiB, 7.11% gc time, 99.77% compilation time)

% julia +1.9 --startup-file=no --project=/tmp -q
julia> using Sandbox; @time @eval Sandbox.select_executor(false);
  2.492451 seconds (4.97 M allocations: 332.907 MiB, 6.76% gc time, 99.71% compilation time)

This PR:

% julia +1.7 --startup-file=no --project=/tmp -q
julia> using Sandbox; @time @eval Sandbox.select_executor(false);
  0.046847 seconds (1.96 k allocations: 120.734 KiB, 100.02% compilation time)

% julia +1.8 --startup-file=no --project=/tmp -q
julia> using Sandbox; @time @eval Sandbox.select_executor(false);
  1.136760 seconds (45.95 k allocations: 2.163 MiB, 99.34% compilation time)

% julia +1.9 --startup-file=no --project=/tmp -q
julia> using Sandbox; @time @eval Sandbox.select_executor(false);
  0.007143 seconds (8.53 k allocations: 526.817 KiB)

This makes this package much more useful for quick usage. Fix #76 (except with v1.8, but it's still faster than without any precompilation statements).

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 79.71% // Head: 79.61% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (422029f) compared to base (da1ccc1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   79.71%   79.61%   -0.11%     
==========================================
  Files           6        6              
  Lines         567      569       +2     
==========================================
+ Hits          452      453       +1     
- Misses        115      116       +1     
Impacted Files Coverage Δ
src/Sandbox.jl 72.80% <0.00%> (-0.65%) ⬇️
src/Docker.jl 86.13% <0.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@staticfloat staticfloat merged commit 02edd8a into JuliaContainerization:main Jan 24, 2023
@giordano giordano deleted the mg/precompilation branch January 24, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select_executor is slow
2 participants